tests: fix flaky TestApplicationsUpgradeOverGossip#6251
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Feb 12, 2025
Merged
tests: fix flaky TestApplicationsUpgradeOverGossip#6251algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6251 +/- ##
=======================================
Coverage 51.77% 51.78%
=======================================
Files 644 644
Lines 86494 86494
=======================================
+ Hits 44781 44787 +6
+ Misses 38843 38841 -2
+ Partials 2870 2866 -4 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Feb 12, 2025
jannotti
approved these changes
Feb 12, 2025
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Changes look correct.
Why the change to not test when "short"? They're slow tests?
cce
approved these changes
Feb 12, 2025
Contributor
Author
yes, longRound cases add 40s more to shortRound tests (18s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newSimpleLedgerFullhelper to create on-disk ledger and ended up polluting local work dir with ledger db files.Test Plan
These are test fixes