Skip to content

API: Block Header API Revamp#6248

Merged
gmalouf merged 4 commits intoalgorand:masterfrom
gmalouf:block-header-api-revamp
Feb 11, 2025
Merged

API: Block Header API Revamp#6248
gmalouf merged 4 commits intoalgorand:masterfrom
gmalouf:block-header-api-revamp

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented Feb 7, 2025

Summary

The recently added algod endpoint /v2/block/{round}/header has proved problematic for downstream SDK support. This PR:

  • Removes that new endpoint entirely (SDK support was not working as-is)
  • Adds a new parameter to /v2/block/{round} that allows a client to request the block header without either the certificate or the payset.

Test Plan

A new parameter test case was added to handlers_test.go.

…sactions and cert from response (algorand#6163)"

This reverts commit a6123b6.
@gmalouf gmalouf added the Bug-Fix label Feb 7, 2025
@gmalouf gmalouf self-assigned this Feb 7, 2025
@gmalouf gmalouf changed the title Revert "… API: Block Header API Revamp Feb 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (c490c22) to head (4f879d5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
daemon/algod/api/server/v2/handlers.go 0.00% 19 Missing ⚠️
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6248   +/-   ##
=======================================
  Coverage   51.77%   51.77%           
=======================================
  Files         644      644           
  Lines       86523    86511   -12     
=======================================
  Hits        44793    44793           
+ Misses      38863    38850   -13     
- Partials     2867     2868    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf requested a review from algorandskiy February 10, 2025 19:32
@gmalouf gmalouf marked this pull request as ready for review February 10, 2025 19:34
@gmalouf gmalouf requested review from cce and jannotti February 10, 2025 19:34
algorandskiy
algorandskiy previously approved these changes Feb 10, 2025
jannotti
jannotti previously approved these changes Feb 11, 2025
Copy link
Copy Markdown
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When does the existing endpoint add certificate bundle? Today, maybe it's only when doing msgpack?

@gmalouf gmalouf dismissed stale reviews from jannotti and algorandskiy via 4f879d5 February 11, 2025 16:43
@gmalouf gmalouf requested a review from jannotti February 11, 2025 16:43
@gmalouf gmalouf requested a review from algorandskiy February 11, 2025 16:48
@gmalouf gmalouf merged commit a46ab5d into algorand:master Feb 11, 2025
@gmalouf gmalouf deleted the block-header-api-revamp branch February 11, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants