API: Block Header API Revamp#6248
Merged
gmalouf merged 4 commits intoalgorand:masterfrom Feb 11, 2025
Merged
Conversation
…sactions and cert from response (algorand#6163)" This reverts commit a6123b6.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6248 +/- ##
=======================================
Coverage 51.77% 51.77%
=======================================
Files 644 644
Lines 86523 86511 -12
=======================================
Hits 44793 44793
+ Misses 38863 38850 -13
- Partials 2867 2868 +1 ☔ View full report in Codecov by Sentry. |
…ing header without either the certificate or corresponding payset.
algorandskiy
previously approved these changes
Feb 10, 2025
jannotti
previously approved these changes
Feb 11, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
When does the existing endpoint add certificate bundle? Today, maybe it's only when doing msgpack?
gmalouf
commented
Feb 11, 2025
jannotti
approved these changes
Feb 11, 2025
algorandskiy
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The recently added algod endpoint
/v2/block/{round}/headerhas proved problematic for downstream SDK support. This PR:/v2/block/{round}that allows a client to request the block header without either the certificate or the payset.Test Plan
A new parameter test case was added to
handlers_test.go.