API: Explicitly set the x-algorand-format for BlockHeaderResponse to 'Bloc…#6247
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Feb 7, 2025
Merged
Conversation
…kHeaderResponse'.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6247 +/- ##
==========================================
+ Coverage 49.25% 51.75% +2.50%
==========================================
Files 644 644
Lines 86521 86521
==========================================
+ Hits 42617 44781 +2164
+ Misses 41040 38872 -2168
- Partials 2864 2868 +4 ☔ View full report in Codecov by Sentry. |
algorandskiy
approved these changes
Feb 7, 2025
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Corresponding generator PR: algorand/generator#85
jannotti
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly set the x-algorand-format for BlockHeaderResponse to 'BlockHeaderResponse'. This allows for downstream code-generators to differentiate between the slightly different msgpack responses on /v2/blocks/{round} and /v2/blocks/{round}/header
Test Plan
Existing checks should all pass.