catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter#6240
Merged
cce merged 16 commits intoalgorand:masterfrom Feb 12, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
==========================================
+ Coverage 51.76% 51.78% +0.02%
==========================================
Files 644 644
Lines 86523 86533 +10
==========================================
+ Hits 44791 44815 +24
+ Misses 38864 38854 -10
+ Partials 2868 2864 -4 ☔ View full report in Codecov by Sentry. |
…lineaccts-horizon
cce
force-pushed
the
fix-catchpoint-onlineaccts-horizon
branch
from
af3bdfb to
ce9b32c
Compare
algorandskiy
previously approved these changes
Feb 11, 2025
jannotti
previously approved these changes
Feb 11, 2025
Contributor
jannotti
left a comment
jannotti
left a comment
There was a problem hiding this comment.
Seems right to me! I don't feel strongly about the Address vs *Address thing. You can resolve if you prefer the pointer.
algorandskiy
previously approved these changes
Feb 11, 2025
jannotti
approved these changes
Feb 11, 2025
algorandskiy
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with onlineaccounts updateRound column for certain accounts in catchpoint files when updateRound < R-320. Renames MakeOnlineAccountsIter to MakeOrderedOnlineAccountsIter (without logic changes) so it is more clear the DB provides an ordering on (account, updround).
Test Plan
Update tests and add new ones.