Skip to content

Devmode: Zero out ProposerPayout when Proposer is not set (which i…#6239

Merged
algorandskiy merged 2 commits intoalgorand:masterfrom
gmalouf:devmode-proposer
Jan 30, 2025
Merged

Devmode: Zero out ProposerPayout when Proposer is not set (which i…#6239
algorandskiy merged 2 commits intoalgorand:masterfrom
gmalouf:devmode-proposer

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented Jan 29, 2025

Summary

In Devmode, zero out ProposerPayout when Proposer is not set (which should be always).

Closes #6236

Test Plan

Existing tests should pass.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.82%. Comparing base (8d01230) to head (92b2a4f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
node/node.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6239      +/-   ##
==========================================
+ Coverage   51.53%   51.82%   +0.29%     
==========================================
  Files         643      643              
  Lines       86382    86384       +2     
==========================================
+ Hits        44513    44770     +257     
+ Misses      38976    38741     -235     
+ Partials     2893     2873      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block proposer omitted when DevMode enabled

3 participants