Skip to content

Testing: Moar unflaky #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 1 commit into from
Jan 13, 2025
Merged

Testing: Moar unflaky #6228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/e2e-go/features/incentives/challenge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,7 @@ func testChallengesOnce(t *testing.T, a *require.Assertions) (retry bool) {
t.Logf("current %d lastPossible %d challengeRound %d", current, lastPossible, challengeRound)

// Advance to challenge round, check the blockseed
err = fixture.WaitForRoundWithTimeout(challengeRound)
a.NoError(err)
blk, err := c2.BookkeepingBlock(challengeRound)
blk, err := fixture.WaitForBlockWithTimeout(challengeRound)
a.NoError(err)
challenge := blk.BlockHeader.Seed[0] & mask // high bit

Expand Down Expand Up @@ -208,6 +206,7 @@ func testChallengesOnce(t *testing.T, a *require.Assertions) (retry bool) {
blk, err = fixture.WaitForBlockWithTimeout(challengeRound + grace + 1)
a.NoError(err)
a.Equal(eligible1, util.MakeSet(blk.AbsentParticipationAccounts...))
c2.WaitForRound(challengeRound + grace + 1) // synch with c2 so next loop is trustworthy

// node 1 challenged (eligible) accounts are suspended because node 1 is off
for address := range match1 {
Expand All @@ -217,7 +216,8 @@ func testChallengesOnce(t *testing.T, a *require.Assertions) (retry bool) {
a.Equal(basics.Offline, data.Status, "%v was not offline in round %d. (%d and %d)",
address, challengeRound+grace+1, data.LastHeartbeat, data.LastProposed)
} else {
a.Equal(basics.Online, data.Status, address) // not eligible, so not suspended
a.Equal(basics.Online, data.Status, "%v was not online in round %d. (%d and %d)",
address, challengeRound+grace+1, data.LastHeartbeat, data.LastProposed) // not eligible, so not suspended
}
a.NotZero(data.VoteID, address)
a.False(data.IncentiveEligible, address) // suspension turns off flag
Expand Down