CI: Remove lnav mac dev dependency#6221
Merged
onetechnical merged 2 commits intomasterfrom Jan 9, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6221 +/- ##
==========================================
- Coverage 51.84% 51.83% -0.01%
==========================================
Files 643 643
Lines 86382 86382
==========================================
- Hits 44781 44778 -3
- Misses 38730 38738 +8
+ Partials 2871 2866 -5 ☔ View full report in Codecov by Sentry. |
onetechnical
reviewed
Jan 9, 2025
Contributor
onetechnical
left a comment
onetechnical
left a comment
There was a problem hiding this comment.
Need to also remove the lnav -i call a couple lines down
algorandskiy
approved these changes
Jan 9, 2025
onetechnical
approved these changes
Jan 9, 2025
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There seems to be an issue on some Mac platforms installing llvm, a dependency of lnav, with homebrew. Removing lnav (a useful but not essential log file viewer tool) from the list of Mac dependencies resolves the issue.
Test Plan
No code change besides this configure_dev.sh script change.