Eval: Move heartbeat verification earlier#6194
Eval: Move heartbeat verification earlier#6194jannotti merged 10 commits intoalgorand:feature/heartbeatsfrom
Conversation
jannotti
force-pushed
the
early-crypto
branch
from
690c647 to
76e433f
Compare
Adds needed fields to HeartbeatTxnFields so that the HbProof can be checked with other signatures (early, and concurrently).
jannotti
force-pushed
the
early-crypto
branch
from
76e433f to
f3b2051
Compare
| } | ||
| if tx.HbKeyDilution == 0 { | ||
| return errors.New("tx.HbKeyDilution is zero") | ||
| } |
There was a problem hiding this comment.
idk, maybe it makes sense to reject HB with empty HbSeed/HbVoteID earlier right here?
There was a problem hiding this comment.
Agreed, I'm adding empty checks.
There was a problem hiding this comment.
Reminder for myself; will look for most of the "is this is a free heartbeat, go draconian" checks (the must be empties) to move here.
There was a problem hiding this comment.
Should I use the tx.<FieldName> construction in error messages universally? It's common in WellFormed.
There was a problem hiding this comment.
See if you like the new error messages.
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
I'm good pending the checks moving into `WellFormed" (and test cases around them).
jannotti
force-pushed
the
early-crypto
branch
from
32ae5db to
24a6a55
Compare
jannotti
force-pushed
the
early-crypto
branch
from
24a6a55 to
e04716e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/heartbeats #6194 +/- ##
======================================================
+ Coverage 50.94% 51.99% +1.05%
======================================================
Files 642 642
Lines 85831 85852 +21
======================================================
+ Hits 43723 44640 +917
+ Misses 39298 38375 -923
- Partials 2810 2837 +27 ☔ View full report in Codecov by Sentry. |
4 participants
Adds needed fields to HeartbeatTxnFields so that the HbProof can be checked with other signatures (early, and concurrently).
Summary
Test Plan