tests: Fix MaxConnectionsPerIP setting in agreement/gossip tests#6173
Merged
gmalouf merged 1 commit intoalgorand:masterfrom Nov 19, 2024
Merged
Conversation
* algorand#6171 decreased MaxConnectionsPerIP default value and it is not enough for agreement/gossip tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6173 +/- ##
==========================================
+ Coverage 51.84% 51.86% +0.02%
==========================================
Files 639 639
Lines 85488 85488
==========================================
+ Hits 44319 44340 +21
+ Misses 38360 38340 -20
+ Partials 2809 2808 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jannotti
approved these changes
Nov 19, 2024
gmalouf
approved these changes
Nov 19, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#6171 decreased MaxConnectionsPerIP default value and it is not enough for agreement/gossip tests.
Here is a failure example for reference.
Test Plan
agreement/gossip tests pass