Fix license errors, enable check_license in travis.#617
Merged
winder merged 2 commits intoalgorand:masterfrom Dec 10, 2019
Merged
Fix license errors, enable check_license in travis.#617winder merged 2 commits intoalgorand:masterfrom
winder merged 2 commits intoalgorand:masterfrom
Conversation
tsachiherman
approved these changes
Dec 9, 2019
Contributor
tsachiherman
left a comment
tsachiherman
left a comment
There was a problem hiding this comment.
I would have preferred that
echo "Running check_license..."
./scripts/check_license.sh
would be in a separate PR, but it's good regardless.
Contributor
Author
That's fair, I'll split up changes better in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to enable this in travis