Incentives: Use agreement round when estimating a node's proposal interval#6164
Merged
jannotti merged 6 commits intoalgorand:feature/heartbeatsfrom Nov 6, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix some bugs in the block incentive scheme related to detecting when an account is absent.
If a node goes online with much more stake than the current total online stake, it could be immediately suspended because it appears to be "absent" in the very round in which it joins.
Because keyreg sets LastHeartbeat to fv, if a txn takes a while to get onto the chain, the account may already be absent.
After going online, a node can't vote for 320 rounds. So, if it joins with, say, 5% of stake, then after 200 rounds it is already absent.