REST API: genesis endpoint schema definition#6157
Conversation
48a93f3 to
9ed9887
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6157 +/- ##
=======================================
Coverage 51.60% 51.60%
=======================================
Files 649 649
Lines 87013 87013
=======================================
+ Hits 44903 44904 +1
Misses 39244 39244
+ Partials 2866 2865 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, added a test to ensure the OpenAPI spec matches the authoritative type and JSON codec tags in bookkeeping.Genesis, which found some missing fields. |
|
@PhearZero - if you want to contribute this, you will need to rebase/merge in from master and then regenerate your schema definitions again after the recent changes. |
|
@PhearZero please remerge with master and run |
|
Thanks! Have been traveling, will bring this up to date. |
|
@PhearZero checking if still wanted to get this to finish line |
|
Absolutely @gmalouf ! Tried to debug this a bit yesterday, I am running into an issue with the generate command: make generate
./scripts/check_deps.sh
[./scripts/check_deps.sh] Required dependencies installed.
PATH=/home/zero/go/bin:$PATH go generate ./...
stringer: no value for constant noop
agreement/actions.go:29: running "stringer": exit status 1
local_defaults.go
2025/04/16 09:17:05
The swagger spec at "./swagger.json" is valid against swagger specification 2.0
stringer: no value for constant NoOpOC
data/transactions/application.go:62: running "stringer": exit status 1
stringer: no value for constant Sender
data/transactions/logic/fields.go:26: running "stringer": exit status 1
stringer: no value for constant AccountHK
ledger/store/trackerdb/hashing.go:32: running "stringer": exit status 1
stringer: no value for constant RoundConcluded
logging/logspec/agreement.go:27: running "stringer": exit status 1
make: *** [Makefile:142: generate] Error 1
I ran (Ubuntu 24.04 go1.23.3 linux/amd64) |
|
@PhearZero can you reinstall your dependencies and dev tools using Go 1.23? Perhaps you upgraded from 1.21 directly without this. See: golang/go#68882 |
# Conflicts: # daemon/algod/api/algod.oas3.yml # daemon/algod/api/server/v2/generated/data/routes.go # daemon/algod/api/server/v2/generated/experimental/routes.go # daemon/algod/api/server/v2/generated/model/types.go # daemon/algod/api/server/v2/generated/nonparticipating/private/routes.go # daemon/algod/api/server/v2/generated/nonparticipating/public/routes.go # daemon/algod/api/server/v2/generated/participating/private/routes.go # daemon/algod/api/server/v2/generated/participating/public/routes.go
|
The error was unrelated and was a user error on my part, I was not targeting the appropriate Thank you for reminding me of this item @gmalouf, should be updated. |
|
@PhearZero it is almost there, please resolve the remaining minor items |
|
@PhearZero Check out the remaining codegen and reviewdog failing checks - minor, but important changes left to get this wrapped up! |
|
@PhearZero because you changed one of the files in the API package, have to re-run the codegen locally and push (check out the codegen verification failure). |
Co-authored-by: cce <51567+cce@users.noreply.github.com>
Summary
Adds Genesis definition for endpoint and fixes invalid "string" response.
Test Plan
make generatemake testto ensure nothing has changed