Incentives: Heartbeat transaction type#6149
Merged
jannotti merged 22 commits intoalgorand:feature/heartbeatsfrom Nov 27, 2024
Merged
Incentives: Heartbeat transaction type#6149jannotti merged 22 commits intoalgorand:feature/heartbeatsfrom
jannotti merged 22 commits intoalgorand:feature/heartbeatsfrom
Conversation
Some TODOS: 1) Lock it down. Singleton group? Top-level? 2) Make it free for challenged nodes. 3) Get the heartbeat service going to keep those nodes online. 4) Move the crypto earlier
jannotti
changed the title
jannotti
force-pushed
the
heartbeat
branch
4 times, most recently
from
936b219 to
9d7d57b
Compare
jannotti
force-pushed
the
heartbeat
branch
8 times, most recently
from
ee3b0d4 to
9162eec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/heartbeats #6149 +/- ##
======================================================
+ Coverage 54.17% 56.39% +2.21%
======================================================
Files 494 497 +3
Lines 70060 70231 +171
======================================================
+ Hits 37957 39605 +1648
+ Misses 29357 27931 -1426
+ Partials 2746 2695 -51 ☔ View full report in Codecov by Sentry. |
The HeartbeatProof type just makes the Heartbeat transactions a little cleaner - they lack the legacy field that OneTimeSignature can't remove.
gmalouf
reviewed
Nov 22, 2024
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
gmalouf
reviewed
Nov 26, 2024
More careful heartbeat in service.go so we don't heartbeat every round, and we use a lower firstValid in case we are slightly ahead of the nodes we send it to. We don't want them to drop it.
gmalouf
approved these changes
Nov 26, 2024
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
I'm good with merging to the feature branch.
gmalouf
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heartbeat/README.md is the best place to read about these changes (along with the payout system that motivated them)