Consensus: For Devnet and Betanet, support custom network upgrade delay#6148
Merged
onetechnical merged 2 commits intoalgorand:masterfrom Oct 11, 2024
Merged
Conversation
…rades delay in consensus parameters during startup.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6148 +/- ##
==========================================
+ Coverage 54.28% 56.24% +1.95%
==========================================
Files 494 494
Lines 69936 69944 +8
==========================================
+ Hits 37968 39343 +1375
+ Misses 29246 27934 -1312
+ Partials 2722 2667 -55 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Oct 10, 2024
cce
reviewed
Oct 10, 2024
cce
approved these changes
Oct 10, 2024
jannotti
approved these changes
Oct 11, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For Devnet and Betanet explicitly, support overriding the ApprovedUpgrades delay in consensus parameters during startup. When merged, this shortens the wait time in pre-release testing processes.
Test Plan
Added new test in consensus.go exercising initializing consensus params across 4 of our supported networks. All existing tests need to pass as well.