Skip to content

network: fix misplaced p2p received TX metric #6144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cce merged 7 commits into from
Oct 28, 2024
Merged

network: fix misplaced p2p received TX metric #6144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4382aa3
network: add algod_peer_p2p_broadcast_dropped_total metric
algorandskiy Sep 25, 2024
50f78ed
fix misplaced recvRPC metric
algorandskiy Sep 25, 2024
8fec6f8
fix metrics diff plotter
algorandskiy Sep 26, 2024
434890a
Update network/metrics.go
algorandskiy Oct 22, 2024
ffd9cb2
Subscribe(pubsub.WithBufferSize(32768))
algorandskiy Oct 3, 2024
6b87e04
fix linter
algorandskiy Oct 22, 2024
db3c714
Merge remote-tracking branch 'upstream/master' into pavel/p2p-more-me…
algorandskiy Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,8 @@ func TestLocal_ValidateP2PHybridConfig(t *testing.T) {

for i, test := range tests {
test := test
t.Run(fmt.Sprintf("test=%d", i), func(t *testing.T) {
name := fmt.Sprintf("test=%d", i)
t.Run(name, func(t *testing.T) {
t.Parallel()

c := Local{
Expand All @@ -782,7 +783,7 @@ func TestLocal_ValidateP2PHybridConfig(t *testing.T) {
NetAddress: test.netAddress,
}
err := c.ValidateP2PHybridConfig()
require.Equal(t, test.err, err != nil, "test=%d", i)
require.Equal(t, test.err, err != nil, name)
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion network/p2p/pubsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func (s *serviceImpl) Subscribe(topic string, val pubsub.ValidatorEx) (SubNextCa
return nil, err
}
// t.SetScoreParams() // already set in makePubSub
return t.Subscribe()
return t.Subscribe(pubsub.WithBufferSize(32768))
}

// Publish publishes data to the given topic
Expand Down