tests: make goal-partkey-commands e2e-subs test serial#6143
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Sep 24, 2024
Merged
tests: make goal-partkey-commands e2e-subs test serial#6143algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6143 +/- ##
==========================================
- Coverage 56.27% 56.26% -0.01%
==========================================
Files 494 494
Lines 69943 69943
==========================================
- Hits 39358 39353 -5
- Misses 27910 27913 +3
- Partials 2675 2677 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Sep 24, 2024
jannotti
approved these changes
Sep 24, 2024
Contributor
jannotti
left a comment
There was a problem hiding this comment.
It would be nice to include the explanation for why this is under serial, but it doesn't matter too much, I suppose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goal-partkey-commands.shfails time to time when checking one vs two node dirs for part keys. There is another test that creates/removed keys so parallel execution lead so flakiness as seen here. Fixed by movinggoal-partkey-commands.shintoserialsub directory.Test Plan
Existing tests should pass.