Merged
Conversation
* these are the last go1.21 compatible
After multiformats/go-multiaddr#235 the test example became invalid, fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6142 +/- ##
==========================================
- Coverage 56.27% 56.27% -0.01%
==========================================
Files 494 494
Lines 69943 69946 +3
==========================================
+ Hits 39358 39359 +1
- Misses 27910 27916 +6
+ Partials 2675 2671 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Sep 25, 2024
gmalouf
reviewed
Sep 25, 2024
jannotti
approved these changes
Sep 25, 2024
Contributor
jannotti
left a comment
There was a problem hiding this comment.
Seems like the crypto changes are minimal, so I don't see any problems.
cce
approved these changes
Sep 26, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded go-libp2p, go-libp2p-pubsub, go-libp2p-pubsub to the latest versions supporting go1.21 (go-libp2p is one patch version behind).
Fixed
*basichost.BasicHostcasting sincelibp2p.Newdoes not return*basichost.BasicHostanymore.Fixed private addresses test:
/ip6/2001:db8::/ipcidr/32is supported natively by multiaddr lib (i.e. fixed a known TODO item)/ip6/200:11::/tcp/1234ended up to be a bad example for testing public IPv6 addresses after some improvements in multiaddrExtra upgrades
Upgrading libp2p also triggered some other dependencies upgrades, notable
golang.org/x/cryptov0.21 -> v0.26.go-algorand directly uses
acme/autocert,,blake2b,sha3,hkdf,nacl/secretboxandscryptsubmodules.The 4 latter (
sha3...scrypt) might potentially affect on-chain data through AVM and kmd.Version history v0.21 -> v0.26 shows only
sha3was changed and both changes (xor, buf) looks good/safe.Test Plan
Existing unit tests. Performance test showed some regression but we have to upgrade anyway.