CI: remove homebrew autoupdate deactivation from CircleCI#6135
Merged
algojohnlee merged 4 commits intoalgorand:masterfrom Sep 18, 2024
Merged
CI: remove homebrew autoupdate deactivation from CircleCI#6135algojohnlee merged 4 commits intoalgorand:masterfrom
algojohnlee merged 4 commits intoalgorand:masterfrom
Conversation
This reverts commit 578889a.
Partially reverts algorand#2608, but we no longer special case some packages and updating brew seems more important.
algorandskiy
approved these changes
Sep 18, 2024
gmalouf
approved these changes
Sep 18, 2024
onetechnical
added a commit
that referenced
this pull request
Sep 18, 2024
This was referenced Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly tests have been failing due to homebrew installation. We're attempting to fix this by not disabling homebrew upgrades.
The error we were getting was this:
The raw github URL here has a typo - it is missing
lib/in the path. Homebrew itself needs to be updated to fix this problem.We specifically avoided updating homebrew in #2608 as a build optimization, but as the default is no longer working and we aren't pinning the dependencies here, we should restore the update.
Test Plan
Try to run nightly tests on this branch.