Skip to content

p2p: exclude self from GetPeers results #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmalouf merged 4 commits into from
Feb 5, 2025
Merged

p2p: exclude self from GetPeers results #6132

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23c611a
p2p: exclude self from GetPeers results
Sep 16, 2024
e2adb71
Merge remote-tracking branch 'upstream/master' into pavel/p2p-get-pee…
Oct 29, 2024
755d714
Merge remote-tracking branch 'upstream/master' into pavel/p2p-get-pee…
Jan 30, 2025
124124d
add unit test
Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions network/p2pNetwork.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,9 @@ func (n *P2PNetwork) GetPeers(options ...PeerOption) []Peer {
const maxNodes = 100
addrInfos := n.pstore.GetAddresses(maxNodes, phonebook.PhoneBookEntryRelayRole)
for _, peerInfo := range addrInfos {
if peerInfo.ID == n.service.ID() {
continue
}
if peerCore, ok := addrInfoToWsPeerCore(n, peerInfo); ok {
peers = append(peers, &peerCore)
}
Expand All @@ -666,6 +669,9 @@ func (n *P2PNetwork) GetPeers(options ...PeerOption) []Peer {
for _, addrInfo := range infos {
// TODO: remove after go1.22
info := addrInfo
if info.ID == n.service.ID() {
continue
}
if peerCore, ok := addrInfoToWsPeerCore(n, &info); ok {
peers = append(peers, &peerCore)
}
Expand Down