network: allow multi-role phonebook entries#6131
Merged
algorandskiy merged 19 commits intoalgorand:masterfrom Feb 27, 2025
Merged
network: allow multi-role phonebook entries#6131algorandskiy merged 19 commits intoalgorand:masterfrom
algorandskiy merged 19 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
==========================================
+ Coverage 51.77% 51.82% +0.05%
==========================================
Files 644 644
Lines 86604 86641 +37
==========================================
+ Hits 44840 44904 +64
+ Misses 38893 38876 -17
+ Partials 2871 2861 -10 ☔ View full report in Codecov by Sentry. |
algorandskiy
commented
Sep 16, 2024
algorandskiy
commented
Sep 16, 2024
cce
reviewed
Sep 27, 2024
cce
reviewed
Sep 27, 2024
cce
reviewed
Sep 27, 2024
jannotti
reviewed
Feb 19, 2025
Co-authored-by: John Jannotti <jannotti@gmail.com>
Co-authored-by: John Jannotti <jannotti@gmail.com>
gmalouf
reviewed
Feb 19, 2025
gmalouf
reviewed
Feb 19, 2025
Contributor
Author
|
Implemented CR suggestions |
jannotti
reviewed
Feb 21, 2025
jannotti
reviewed
Feb 26, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
I'm ok with this. I'll wait for a little discussion about reusing the same type, but I could approve as is.
Contributor
Author
|
Updated comments are requested |
gmalouf
approved these changes
Feb 26, 2025
jannotti
approved these changes
Feb 27, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meshThreadfromGetPeers:GeetPeersbe non-network query dependentpersistedflag and move to per-role intoRoleSetTest Plan
Added unit tests for multi roles peers in phonebook and peerstore wrapper.