p2p: store private keys as PKCS#8 ASN.1 DER PEM#6119
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Sep 3, 2024
Merged
p2p: store private keys as PKCS#8 ASN.1 DER PEM#6119algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
c2f7769 to
fda04b3
Compare
cce
reviewed
Sep 3, 2024
cce
previously approved these changes
Sep 3, 2024
fda04b3 to
52027bd
Compare
cce
approved these changes
Sep 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6119 +/- ##
==========================================
- Coverage 56.20% 56.18% -0.03%
==========================================
Files 492 492
Lines 69829 69851 +22
==========================================
- Hits 39248 39244 -4
- Misses 27915 27924 +9
- Partials 2666 2683 +17 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before: p2p private key is stored raw in *.pem file. It is misleading since it does not contain an expected PEM content.
After: ED25519 key encoded as PKCS#8 ASN.1 DER and stored in PEM format, block type "PRIVATE KEY" in a *.key file.
Note: this implementation relies
libp2p/crypto's implementation details that it uses golang's standardcrypto.ed25519.PrivateKeyunderlying representation. It looks OK since we already have the same assumption inPeerIDChallengeSignerimplementation.Test Plan
Existing tests passed
Checked
opensslunderstand this key