metrics: collect total netdev sent/received bytes#6108
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Aug 28, 2024
Merged
metrics: collect total netdev sent/received bytes#6108gmalouf merged 2 commits intoalgorand:masterfrom
gmalouf merged 2 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6108 +/- ##
==========================================
- Coverage 56.22% 56.19% -0.04%
==========================================
Files 490 492 +2
Lines 69705 69775 +70
==========================================
+ Hits 39191 39207 +16
- Misses 27840 27898 +58
+ Partials 2674 2670 -4 ☔ View full report in Codecov by Sentry. |
176c07f to
fa214fe
Compare
fa214fe to
26490b6
Compare
gmalouf
approved these changes
Aug 23, 2024
cce
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose total number of bytes sent/received on network interfaces. This is similar to node_exporter data but works without
node_exporter. It is gated behind theEnableNetDevMetricsnew config option.Test Plan
Tested locally on both MacOS and Linux
We also have some tools to render and summarize these tagged metrics:
Or non-tagged ones to CVS