AVM: Provide access to some more block header values#6107
Merged
jannotti merged 4 commits intoalgorand:masterfrom Sep 3, 2024
Merged
AVM: Provide access to some more block header values#6107jannotti merged 4 commits intoalgorand:masterfrom
jannotti merged 4 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6107 +/- ##
==========================================
- Coverage 56.27% 56.27% -0.01%
==========================================
Files 490 490
Lines 69710 69720 +10
==========================================
+ Hits 39230 39234 +4
- Misses 27817 27819 +2
- Partials 2663 2667 +4 ☔ View full report in Codecov by Sentry. |
algorandskiy
previously approved these changes
Aug 23, 2024
jasonpaulos
reviewed
Aug 26, 2024
Contributor
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good but I did want to call attention to the change in values for the other v11 block fields
e3ae2ee to
4fdcff6
Compare
jasonpaulos
approved these changes
Aug 28, 2024
algorandskiy
approved these changes
Sep 3, 2024
onetechnical
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of block incentives, there are good reasons to expose the FeeSink and the ProposerPayout from the block header to AVM using the block opcode. While doing that, we can consider a few more things that might be useful.
Currently this PR exposes these.