REST API: Fix LedgerStateDelta JSON encoding#6106
Merged
jasonpaulos merged 14 commits intoalgorand:masterfrom Aug 29, 2024
Merged
REST API: Fix LedgerStateDelta JSON encoding#6106jasonpaulos merged 14 commits intoalgorand:masterfrom
LedgerStateDelta JSON encoding#6106jasonpaulos merged 14 commits intoalgorand:masterfrom
Conversation
LedgerStateDelta JSON encoding
jannotti
reviewed
Aug 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6106 +/- ##
==========================================
+ Coverage 56.25% 56.26% +0.01%
==========================================
Files 490 490
Lines 69699 69704 +5
==========================================
+ Hits 39206 39222 +16
+ Misses 27825 27822 -3
+ Partials 2668 2660 -8 ☔ View full report in Codecov by Sentry. |
Ashy5000
reviewed
Aug 20, 2024
jasonpaulos
commented
Aug 23, 2024
jasonpaulos
commented
Aug 23, 2024
jasonpaulos
commented
Aug 23, 2024
jannotti
previously approved these changes
Aug 26, 2024
Contributor
jannotti
left a comment
There was a problem hiding this comment.
This looks like a fine fix to make sure the leases can be emitted as valid JSON. On the other hand, I'm struggling to see any value in sending the lease information at all, since it is very explicit already in the transaction (the sender, the lease, and the implied expiration from last valid).
Anyway, I'm ok with this, or zeroing the leases map before creating JSON.
jannotti
previously approved these changes
Aug 28, 2024
gmalouf
reviewed
Aug 28, 2024
gmalouf
reviewed
Aug 28, 2024
gmalouf
previously approved these changes
Aug 28, 2024
gmalouf
approved these changes
Aug 29, 2024
jannotti
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
Txleasesfield from JSON state delta representations, as this field cannot be properly JSON encoded.Based on #6100
Closes #6097
Test Plan
Test coverage added on all 3 endpoints.