Skip to content

config: use P2PHybridIncomingConnectionsLimit only for hybrid mode#6103

Merged
algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy:pavel/p2p-config-tweaks
Aug 28, 2024
Merged

config: use P2PHybridIncomingConnectionsLimit only for hybrid mode#6103
algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy:pavel/p2p-config-tweaks

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

@algorandskiy algorandskiy commented Aug 15, 2024

Summary

  1. Make P2PIncomingConnectionsLimit consistent with P2PNetAddress and use it only for hybrid configuration.
  2. Rename P2PIncomingConnectionsLimit and P2PNetAddress to P2PHybridIncomingConnectionsLimit P2PHybridNetAddress to make it clear these are only for Hybrid mode.

Test Plan

config unit test extended.

@algorandskiy algorandskiy added Enhancement p2p Work related to the p2p project labels Aug 15, 2024
@algorandskiy algorandskiy self-assigned this Aug 15, 2024
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding back approval, as I'm getting apprehensive about the setting names/impacts in P2P only vs hybrid mode.

Comment thread config/localTemplate.go Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.25%. Comparing base (8e2e2e4) to head (e53ceb9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
daemon/algod/server.go 0.00% 10 Missing ⚠️
netdeploy/remote/deployedNetwork.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6103      +/-   ##
==========================================
+ Coverage   56.22%   56.25%   +0.03%     
==========================================
  Files         490      490              
  Lines       69705    69708       +3     
==========================================
+ Hits        39191    39214      +23     
+ Misses      27840    27823      -17     
+ Partials     2674     2671       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy changed the title config: use P2PIncomingConnectionsLimit only for hybrid mode config: use P2PHybridIncomingConnectionsLimit only for hybrid mode Aug 26, 2024
@algorandskiy algorandskiy requested a review from gmalouf August 28, 2024 15:29
@algorandskiy algorandskiy merged commit 8d678c3 into algorand:master Aug 28, 2024
@algorandskiy algorandskiy deleted the pavel/p2p-config-tweaks branch March 16, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement p2p Work related to the p2p project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants