docs: p2p package overview#6096
Conversation
f20f860 to
bcd818f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6096 +/- ##
==========================================
- Coverage 56.25% 55.93% -0.32%
==========================================
Files 490 490
Lines 69699 69706 +7
==========================================
- Hits 39206 38993 -213
- Misses 27825 28004 +179
- Partials 2668 2709 +41 ☔ View full report in Codecov by Sentry. |
bcd818f to
c1cd118
Compare
13e8d67 to
edcdda5
Compare
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good I have just a few minor comments
Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com>
gmalouf
left a comment
There was a problem hiding this comment.
Put in some wording suggestions for the READMEs along with a question about the isGossipServer checks.
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
|
@jasonpaulos / @gmalouf thank you for corrections! All applied. |
gmalouf
left a comment
There was a problem hiding this comment.
Overall I like - I do wonder where we put the clear recommendation to bias towards using the appropriate hybrid profiles (and making sure they are aware of the appropriate settings) for users interesting in exercising the P2P network out of the gate.
Summary
network/p2p/README.mdnetwork/README-P2P.mdWhile writing this doc found and fixed the following:
peer.GetHTTPClient()returning nil sinceMakeHTTPClientfor p2p net can err.