tests: fix e2e subs goal-partkey-commands#6095
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Aug 7, 2024
Merged
Conversation
5322c9b to
76fa7dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6095 +/- ##
==========================================
- Coverage 56.26% 56.23% -0.04%
==========================================
Files 489 489
Lines 69637 69637
==========================================
- Hits 39182 39157 -25
- Misses 27796 27817 +21
- Partials 2659 2663 +4 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Aug 7, 2024
jasonpaulos
approved these changes
Aug 7, 2024
cce
added a commit
to cce/go-algorand
that referenced
this pull request
Aug 30, 2024
…caught it earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goal-partkey-commands was extremely buggy:
set -e)Also added
TESTFILTERhandling to e2e-subs so it can run a single test now (similarly to expect tests).Test Plan
This is a test fix, passed locally