Skip to content

tests: fix e2e subs goal-partkey-commands#6095

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/e2e-subs-part-key
Aug 7, 2024
Merged

tests: fix e2e subs goal-partkey-commands#6095
algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy:pavel/e2e-subs-part-key

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

goal-partkey-commands was extremely buggy:

  1. Uses non-initialized gcmd and INITIAL_ACCOUNT
  2. Does not check if cmd fails (no set -e)
  3. Part key command output parsing was invalid.
  4. Sometimes it raced with some other test and failed to correctly compare part keys. This was fixed by binding goal cmd to a wallet (the runner creates unique wallets for each test).

Also added TESTFILTER handling to e2e-subs so it can run a single test now (similarly to expect tests).

Test Plan

This is a test fix, passed locally

@algorandskiy algorandskiy force-pushed the pavel/e2e-subs-part-key branch from 5322c9b to 76fa7dc Compare August 6, 2024 21:16
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.23%. Comparing base (d2c4ca7) to head (76fa7dc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6095      +/-   ##
==========================================
- Coverage   56.26%   56.23%   -0.04%     
==========================================
  Files         489      489              
  Lines       69637    69637              
==========================================
- Hits        39182    39157      -25     
- Misses      27796    27817      +21     
- Partials     2659     2663       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 9924574 into algorand:master Aug 7, 2024
cce added a commit to cce/go-algorand that referenced this pull request Aug 30, 2024
@algorandskiy algorandskiy deleted the pavel/e2e-subs-part-key branch March 16, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants