netgoal: allow unknown template tokens#6091
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Aug 1, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6091 +/- ##
==========================================
+ Coverage 55.88% 56.26% +0.37%
==========================================
Files 488 488
Lines 69610 69612 +2
==========================================
+ Hits 38901 39165 +264
+ Misses 28042 27782 -260
+ Partials 2667 2665 -2 ☔ View full report in Codecov by Sentry. |
cce
approved these changes
Aug 1, 2024
jasonpaulos
approved these changes
Aug 1, 2024
gmalouf
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new option
-i/--ignoretonetgoal buildto suppress errors likeerror building network files: error loading Network Config file 'net.json': config file contains unrecognized token: {{.Year}}when usingLogArchiveNametemplating inConfigJSONOverrideAlso renamed
ErrDeployedNetworkTemplateerror type todeployedNetworkTemplateErrorto match err val vs err type convention used in other parts of the code base (err- prefix for values, -Error suffix for types).Test Plan
Tested locally