cmd: Add goal node subcommand to generate peer private key#6078
Merged
algorandskiy merged 6 commits intoalgorand:masterfrom Aug 1, 2024
Merged
cmd: Add goal node subcommand to generate peer private key#6078algorandskiy merged 6 commits intoalgorand:masterfrom
algorandskiy merged 6 commits intoalgorand:masterfrom
Conversation
f8c6534 to
9b23a43
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6078 +/- ##
==========================================
+ Coverage 55.95% 56.26% +0.30%
==========================================
Files 488 489 +1
Lines 69602 69627 +25
==========================================
+ Hits 38945 39173 +228
+ Misses 27967 27802 -165
+ Partials 2690 2652 -38 ☔ View full report in Codecov by Sentry. |
jasonpaulos
reviewed
Jul 23, 2024
Contributor
jasonpaulos
left a comment
There was a problem hiding this comment.
Makes sense, just one comment
jasonpaulos
reviewed
Jul 23, 2024
jasonpaulos
previously approved these changes
Jul 24, 2024
cce
previously approved these changes
Jul 26, 2024
Contributor
cce
left a comment
There was a problem hiding this comment.
LGTM, though it may make sense to move this to be a goal subcommand later, for node operators who want to generate persistent p2p IDs.
Contributor
Author
|
Like |
Contributor
Author
|
Implemented as |
jasonpaulos
reviewed
Jul 30, 2024
jasonpaulos
reviewed
Jul 30, 2024
jasonpaulos
approved these changes
Jul 31, 2024
cce
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of upcoming p2p deployment we need to register p2p bootstrap nodes in DNS TXT.
This tool allows to generate a new peer private key and print out peer ID (or print it from existing key file with default name).
Test Plan
Tested manually