p2p: support EnableGossipService in p2p streams#6073
Merged
algorandskiy merged 5 commits intoalgorand:masterfrom Jul 29, 2024
Merged
p2p: support EnableGossipService in p2p streams#6073algorandskiy merged 5 commits intoalgorand:masterfrom
algorandskiy merged 5 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
+ Coverage 55.95% 56.30% +0.34%
==========================================
Files 488 488
Lines 69602 69595 -7
==========================================
+ Hits 38945 39182 +237
+ Misses 27967 27763 -204
+ Partials 2690 2650 -40 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Jul 19, 2024
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
One still is receiving blocks and certs when gossip service is disabled right? Do we doublecheck that/is it worth doublechecking that?
gmalouf
previously approved these changes
Jul 19, 2024
jasonpaulos
reviewed
Jul 23, 2024
jasonpaulos
previously approved these changes
Jul 25, 2024
nullun
reviewed
Jul 26, 2024
Contributor
Author
|
Merged master into |
jasonpaulos
approved these changes
Jul 29, 2024
gmalouf
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
EnableGossipServicesupport to p2p net: stream manager checks connection direction and either does not open a new/algorand-ws/1.0.0(inConnectednotification) or closes incoming stream in a stream handler.Additionally I removed useless incoming vs outgoing checks with warnings since their assumption are wrong:
Connectednotification is fired for both incoming and outgoing connections.Test Plan
Added tests to ensure:
EnableGossipService=falsecan still accept and send trafficEnableGossipService=falsecannot communicate.