CI: update nightly builds to use universal mac update#6071
Merged
onetechnical merged 12 commits intoalgorand:masterfrom Jul 25, 2024
Merged
CI: update nightly builds to use universal mac update#6071onetechnical merged 12 commits intoalgorand:masterfrom
onetechnical merged 12 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6071 +/- ##
==========================================
- Coverage 56.13% 56.11% -0.02%
==========================================
Files 488 488
Lines 69439 69445 +6
==========================================
- Hits 38978 38968 -10
- Misses 27813 27823 +10
- Partials 2648 2654 +6 ☔ View full report in Codecov by Sentry. |
Contributor
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM, one remark about naked return stmt.
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
approved these changes
Jul 25, 2024
cce
approved these changes
Jul 25, 2024
This was referenced Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #6023 we added a universal mac build target. We should switch to this as it's a simplified model for handling Mac binaries. This PR takes the first step by migrating our nightly builds to use this by default.
Note that I did not want to just make Mac universal builds the default for
make build. It does, however, presume if you runmake universalthat you want that as your primary binary.Also removed arm32 from the updater script, as that platform support has been deprecated.
Test Plan
Been running steps individually, but will also need to see if nightly build/promotion works.