rest api: Fix to Disable API authentication#6067
Merged
gmalouf merged 3 commits intoalgorand:masterfrom Jul 15, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6067 +/- ##
==========================================
+ Coverage 55.77% 56.17% +0.39%
==========================================
Files 488 488
Lines 69434 69437 +3
==========================================
+ Hits 38730 39008 +278
+ Misses 28017 27791 -226
+ Partials 2687 2638 -49 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Jul 15, 2024
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
This looks right to me. The auth middleware gets disabled on public AI endpoints if no token is passed at startup (noting that admin auth still gets enabled int he proper places). Small comments to look at before approving.
Contributor
|
closes #5747 |
algorandskiy
commented
Jul 15, 2024
Co-authored-by: Gary Malouf <982483+gmalouf@users.noreply.github.com>
gmalouf
previously approved these changes
Jul 15, 2024
algorandskiy
commented
Jul 15, 2024
gmalouf
approved these changes
Jul 15, 2024
jasonpaulos
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix to #5625 where incorrect test with a client always using an adminToken lead to incorrect actual implementation.
Test Plan
Fixed an existing e2e test