P2P: Add DisableRelayP2PTransport param to expose ability for certain node…#6063
Closed
gmalouf wants to merge 1 commit intoalgorand:masterfrom
Closed
P2P: Add DisableRelayP2PTransport param to expose ability for certain node…#6063gmalouf wants to merge 1 commit intoalgorand:masterfrom
gmalouf wants to merge 1 commit intoalgorand:masterfrom
Conversation
… classes to not gossip messages on the P2P network (while still connecting to it).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6063 +/- ##
==========================================
- Coverage 56.11% 56.11% -0.01%
==========================================
Files 488 488
Lines 69437 69439 +2
==========================================
- Hits 38966 38965 -1
+ Misses 27821 27817 -4
- Partials 2650 2657 +7 ☔ View full report in Codecov by Sentry. |
Contributor
algorandskiy
left a comment
algorandskiy
left a comment
There was a problem hiding this comment.
Missing a unit test
| // the libp2p.NoListenAddrs builtin disables relays but this one does not | ||
| var noListenAddrs = func(cfg *libp2p.Config) error { | ||
| cfg.ListenAddrs = []multiaddr.Multiaddr{} | ||
| // the libp2p.NoListenAddrs builtin disables relays but this one only does if |
Contributor
There was a problem hiding this comment.
this is technically right but I think two separate opts noListenAddrNoRelay := libp2p.NoListenAddrs(p2pCfg) and noListenAddrs := func... p2pCfg.ListenAddrs = []multiaddr.Multiaddr{} could be more clear?
Contributor
Author
|
Closing in favor of #6064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add DisableRelayP2PTransport param to expose ability for certain node classes to not gossip messages on the P2P network (while still connecting to it).
Test Plan
Existing tests should pass.