P2P: Introduce profiles for hybridRelay, hybridArchival, and hybridClient.#6062
Merged
gmalouf merged 9 commits intoalgorand:masterfrom Jul 18, 2024
Merged
P2P: Introduce profiles for hybridRelay, hybridArchival, and hybridClient.#6062gmalouf merged 9 commits intoalgorand:masterfrom
gmalouf merged 9 commits intoalgorand:masterfrom
Conversation
Contributor
Author
|
closes #6043 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6062 +/- ##
==========================================
+ Coverage 55.77% 56.20% +0.42%
==========================================
Files 488 488
Lines 69434 69469 +35
==========================================
+ Hits 38730 39046 +316
+ Misses 28017 27783 -234
+ Partials 2687 2640 -47 ☔ View full report in Codecov by Sentry. |
onetechnical
previously approved these changes
Jul 11, 2024
Contributor
onetechnical
left a comment
onetechnical
left a comment
There was a problem hiding this comment.
Overall looks good, but had a couple comments.
cce
reviewed
Jul 11, 2024
gmalouf
force-pushed
the
p2p-config-options
branch
from
a20c91e to
e8feae1
Compare
…isten port for hybridClient profile.
…ten port when NetAddress is not set in p2p mode.
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
…with 'placeholder' set as if it was empty.
gmalouf
commented
Jul 18, 2024
algorandskiy
previously approved these changes
Jul 18, 2024
Co-authored-by: Pavel Zbitskiy <65323360+algorandskiy@users.noreply.github.com>
algorandskiy
approved these changes
Jul 18, 2024
onetechnical
approved these changes
Jul 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce configuration profiles for hybrid (WS+P2P support) relays, archival nodes, and part/non-participating role nodes.
Test Plan
Unit tests were added in
profileCommand_test.gofor each new profile. All 3 configurations were tested being generated via algocfg CLI, with each also used on a running local node.