tests: increase ListPeersForTopic wait time in TestP2PRelay#6056
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Jul 8, 2024
Merged
tests: increase ListPeersForTopic wait time in TestP2PRelay#6056algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
gmalouf
approved these changes
Jul 8, 2024
cce
approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6056 +/- ##
==========================================
- Coverage 56.21% 56.15% -0.06%
==========================================
Files 488 488
Lines 69432 69432
==========================================
- Hits 39030 38990 -40
- Misses 27761 27789 +28
- Partials 2641 2653 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestP2PRelayfailures (one, two) indicate netC messages get lost. Most likely it is not enough time for pubsub to establish its mesh so increased wait time to stabilize the test.Test Plan
This is a test fix