catchup: skip logging err for catchup cancellation#6053
catchup: skip logging err for catchup cancellation#6053algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
|
I'm not sure if we want to just drop these messages completely. The two contexts I see this firing for recently are:
|
algorandskiy
left a comment
There was a problem hiding this comment.
fetchAndWrite(%v) vs fetchAndWrite(%d) is inconsistent in this file, all need to be %d (or %v) eventually.
|
Please rebase/merge master - it as some flaky test fixes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6053 +/- ##
==========================================
- Coverage 56.13% 56.11% -0.02%
==========================================
Files 488 488
Lines 69439 69439
==========================================
- Hits 38978 38965 -13
- Misses 27813 27821 +8
- Partials 2648 2653 +5 ☔ View full report in Codecov by Sentry. |
cce
left a comment
There was a problem hiding this comment.
LGTM, if you really want to see every error you can turn on debug-level logging. the ctx.Done() will occur when pipelinedFetch() finishes, so the reasons for it finishing would be logged inside pipelinedFetch.
Should logging err value here as we have no access to the original cause for abort.