logging: change transaction pool re-evaluation message from warn to info#6047
Merged
algorandskiy merged 3 commits intoalgorand:masterfrom Jul 10, 2024
Merged
logging: change transaction pool re-evaluation message from warn to info#6047algorandskiy merged 3 commits intoalgorand:masterfrom
algorandskiy merged 3 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6047 +/- ##
=======================================
Coverage 56.16% 56.16%
=======================================
Files 488 488
Lines 69432 69437 +5
=======================================
+ Hits 38995 38999 +4
- Misses 27792 27794 +2
+ Partials 2645 2644 -1 ☔ View full report in Codecov by Sentry. |
algorandskiy
previously approved these changes
Jul 1, 2024
cce
commented
Jul 3, 2024
gmalouf
previously approved these changes
Jul 3, 2024
onetechnical
approved these changes
Jul 8, 2024
Contributor
algorandskiy
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This splits out a common case, when a transaction cannot persist in the transaction pool because the latest block has rendered the TEAL code to be no longer valid. It should not be a warning as it is a common occurrence.
Test Plan
Only changes to logging and stats, existing tests should pass.