Skip to content

libgoal: output debug info on failure to stderr #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 2 commits into from
Jun 12, 2024
Merged

libgoal: output debug info on failure to stderr #6027

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bdb56d
libgoal: output debug info on failure to stderr
algorandskiy Jun 12, 2024
4b2d300
add new line term after end of logs
algorandskiy Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions test/framework/fixtures/libgoalFixture.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (f *LibGoalFixture) nodeExitWithError(nc *nodecontrol.NodeController, err e
}

debugLog := func() {
f.t.Logf("Node at %s has terminated with an error: %v. Dumping logs...", nc.GetDataDir(), err)
fmt.Fprintf(os.Stderr, "Node at %s has terminated with an error: %v. Dumping logs...", nc.GetDataDir(), err)
f.dumpLogs(filepath.Join(nc.GetDataDir(), "node.log"))
}

Expand All @@ -158,7 +158,7 @@ func (f *LibGoalFixture) nodeExitWithError(nc *nodecontrol.NodeController, err e
ws := exitError.Sys().(syscall.WaitStatus)
exitCode := ws.ExitStatus()

f.t.Logf("Node at %s has terminated with error code %d (%v)", nc.GetDataDir(), exitCode, *exitError)
fmt.Fprintf(os.Stderr, "Node at %s has terminated with error code %d (%v)", nc.GetDataDir(), exitCode, *exitError)
debugLog()
require.NoError(f.t, err)
}
Expand Down Expand Up @@ -369,18 +369,19 @@ func (f *LibGoalFixture) ShutdownImpl(preserveData bool) {
func (f *LibGoalFixture) dumpLogs(filePath string) {
file, err := os.Open(filePath)
if err != nil {
f.t.Logf("could not open %s", filePath)
fmt.Fprintf(os.Stderr, "could not open %s", filePath)
return
}
defer file.Close()

f.t.Log("=================================\n")
fmt.Fprintf(os.Stderr, "=================================\n")
parts := strings.Split(filePath, "/")
f.t.Logf("%s/%s:", parts[len(parts)-2], parts[len(parts)-1]) // Primary/node.log
fmt.Fprintf(os.Stderr, "%s/%s:", parts[len(parts)-2], parts[len(parts)-1]) // Primary/node.log
scanner := bufio.NewScanner(file)
for scanner.Scan() {
f.t.Logf(scanner.Text())
fmt.Fprint(os.Stderr, scanner.Text())
}
fmt.Fprintln(os.Stderr)
}

// intercept baseFixture.failOnError so we can clean up any algods that are still alive
Expand Down