tests: debug output on LibGoalFixture failure#6026
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Jun 11, 2024
Merged
tests: debug output on LibGoalFixture failure#6026algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
gmalouf
approved these changes
Jun 11, 2024
jasonpaulos
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LibGoalFixture sometimes detects node termination error but it panics since test assert is called after test's main goroutine termination:
So that we observe this panic message instead an actual debug output with error code and node.log content. This PR changes the sequence - log all available info first and only then assert and fail.
Test Plan
This is a test harness change.