AVM: Expose relevant incentive constants#6025
Merged
gmalouf merged 2 commits intoalgorand:masterfrom Jun 11, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6025 +/- ##
==========================================
+ Coverage 55.96% 55.97% +0.01%
==========================================
Files 482 482
Lines 68287 68297 +10
==========================================
+ Hits 38214 38228 +14
+ Misses 27476 27474 -2
+ Partials 2597 2595 -2 ☔ View full report in Codecov by Sentry. |
gmalouf
previously approved these changes
Jun 11, 2024
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
This looks very straightforward to me, left nit(s) and question.
jasonpaulos
reviewed
Jun 11, 2024
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
The maximum typo should be corrected, but otherwise this looks good
jasonpaulos
approved these changes
Jun 11, 2024
gmalouf
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create global constants for some of the protocol constants introduced with the block incentive mechanism.
Resolves #5998