config: Add GoMemLimit config option and use with 10-node test#5975
Merged
algorandskiy merged 4 commits intoalgorand:masterfrom Jun 12, 2024
Merged
config: Add GoMemLimit config option and use with 10-node test#5975algorandskiy merged 4 commits intoalgorand:masterfrom
algorandskiy merged 4 commits intoalgorand:masterfrom
Conversation
…se it for 10 nodes * 1GB limit
cce
reviewed
Apr 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5975 +/- ##
=======================================
Coverage 56.00% 56.00%
=======================================
Files 481 481
Lines 67646 67648 +2
=======================================
+ Hits 37883 37887 +4
- Misses 27197 27200 +3
+ Partials 2566 2561 -5 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Apr 8, 2024
gmalouf
reviewed
Apr 8, 2024
…erCatchpointCatchup
gmalouf
approved these changes
May 15, 2024
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
I think a config option is reasonable enough, understanding we may want to later remove if Golang changes the expected behavior/approach.
Contributor
algorandskiy
left a comment
There was a problem hiding this comment.
LGTM but lets merge after p2p branch since it also adds v34 config, and rebasing this smaller PR will be easier.
algorandskiy
approved these changes
Jun 12, 2024
Contributor
algorandskiy
left a comment
There was a problem hiding this comment.
Well although feature/p2p has a conflict so requires manual remerge anyway, lets get it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a config option GoMemLimit for a soft memory limit like GOMEMLIMIT. It uses it for TestPartitionHalfOffline which runs 10 nodes (TenNodesDistributedMultiWallet.json) for 1GB each. It also uses it for TestSendSigsAfterCatchpointCatchup which starts 3 nodes and has one generate a catchpoint snapshot for the others.
Test Plan
TestPartitionHalfOffline should run 10 nodes without using as much memory, and TestSendSigsAfterCatchpointCatchup should also use less memory.