p2p: test scenarios support#5962
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5962 +/- ##
=============================================
Coverage 56.01% 56.02%
=============================================
Files 495 497 +2
Lines 69009 69130 +121
=============================================
+ Hits 38657 38731 +74
- Misses 27730 27774 +44
- Partials 2622 2625 +3 ☔ View full report in Codecov by Sentry. |
69cb867 to
a5ccfcb
Compare
3a7e767 to
79251d0
Compare
09a16c1 to
d2d2e3a
Compare
There was a problem hiding this comment.
the idea is to have it dependency-free so it can be run on a remote machine with logs
92b7d16 to
9c63601
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5962 +/- ##
===============================================
- Coverage 56.13% 56.12% -0.02%
===============================================
Files 487 488 +1
Lines 69327 69396 +69
===============================================
+ Hits 38919 38946 +27
- Misses 27760 27800 +40
- Partials 2648 2650 +2 ☔ View full report in Codecov by Sentry. |
e105157 to
cb06762
Compare
| loggingFields[f.Key] = f.Interface | ||
| } else { | ||
| loggingFields[f.Key] = f.Integer | ||
| } |
There was a problem hiding this comment.
I guess it is OK to ignore the field type because they all boil down to one of these three types?
| n.log.With("event", event).With("remote", addr).With("local", localAddr).Infof(msg, p2ppeer.String()) | ||
| localAddr, has := n.Address() | ||
| if !has { | ||
| n.log.Warn("Could not get local address") |
There was a problem hiding this comment.
not sure but it did happen few times - discovered when parsed node.log files for topology images.
Summary
DNSSecurityTXTEnforceduse for DNS TXT queries instead ofDNSSecuritySRVEnforcedgossipSubPeer.RoutingAddrimplementation needed for TX handler when throttled with ERLzapcore.Corewriting vialogger.LoggerExample log records
Test Plan