API: Experimental full assets for account endpoint. #5948
Merged
+2,782
−1,379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5948 +/- ##
==========================================
- Coverage 56.18% 55.97% -0.21%
==========================================
Files 482 482
Lines 67989 68287 +298
==========================================
+ Hits 38199 38225 +26
- Misses 27201 27462 +261
- Partials 2589 2600 +11 ☔ View full report in Codecov by Sentry. |
jannotti
reviewed
Mar 6, 2024
jasonpaulos
reviewed
Mar 6, 2024
|
Thank you!! |
algorandskiy
reviewed
Mar 7, 2024
jasonpaulos
reviewed
Mar 7, 2024
gmalouf
force-pushed
the
asset-fullparams-batch-endpoint
branch
from
4a3c512
to
38201ed
Compare
jasonpaulos
reviewed
Apr 8, 2024
jasonpaulos
reviewed
Apr 10, 2024
cce
reviewed
Apr 22, 2024
jasonpaulos
reviewed
Apr 29, 2024
gmalouf
force-pushed
the
asset-fullparams-batch-endpoint
branch
from
caef69c
to
bbbd3c6
Compare
…t includes always grabbing corresponding asset parameters, supporting pagination via the next / limit parameters, and enforcing max batch caps.
… any existing asset ids for the account.
…query one item extra each time to see if we have actually tokenized through all results before returning. Handler now deals with asset params being optional (in the case of a deleted asset).
…against asset creator information iff it is available. Updated result parsing logic to handle this data conditionally being present. Added new functional test exercising the limit query itself, including several failure modes. Lastly, tweak handler to check if creator address is set to its zero value in determining whether to return result with asset params set.
…ata blob matches as both an asset and app.
…aging a left join with assetcreators to populate much of the ctypes on updated resources table.
…aving to create another table and full copy.
…tchpoint and setting the db version properly (to ensure columns present during prepared statement init).
gmalouf
force-pushed
the
asset-fullparams-batch-endpoint
branch
from
eb6864a
to
963027d
Compare
gmalouf
commented
May 1, 2024
gmalouf
commented
May 1, 2024
jasonpaulos
reviewed
May 1, 2024
algorandskiy
previously approved these changes
May 2, 2024
jasonpaulos
reviewed
May 3, 2024
Co-authored-by: Jason Paulos <[email protected]>
jasonpaulos
approved these changes
May 3, 2024
algorandskiy
approved these changes
May 3, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support includes always grabbing corresponding asset parameters, supporting pagination via the next / limit parameters, and enforcing max batch caps. Support for this endpoint has also been added to goal, keeping in mind this is experimental for this initial release.
Closes #5250
Test Plan
Initial smoke tests against a caught up testnet node showed the pagination and limit queries working well. Added functional tests for the handler and query layers respectively.