Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: use network context for DNS operations in readFromSRV #5936

Merged

Conversation

algorandskiy
Copy link
Contributor

Summary

  • Pending DNS operations might cause delay on node shutdown
  • Providing a cancellable context to underlying resolver would about operations that could stuck in timeout otherwise

Test Plan

Existing tests should pass.
I narrowed down the e2e_basic_start_stop.sh sporadic failures to wsNetwork.meshThread that makes me think DNS lookup timeouts might be responsible for that.

* Pending DNS operations might cause delay on node shutdown
* Providing a cancellable context to underlying resolver would about
  operations that could stuck in timeout otherwise
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (caec33d) 55.73% compared to head (5d5539d) 55.71%.

Files Patch % Lines
tools/network/bootstrap.go 85.71% 1 Missing ⚠️
tools/network/telemetryURIUpdateService.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5936      +/-   ##
==========================================
- Coverage   55.73%   55.71%   -0.03%     
==========================================
  Files         487      487              
  Lines       68048    68048              
==========================================
- Hits        37927    37911      -16     
- Misses      27561    27572      +11     
- Partials     2560     2565       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of wsNetwork, we still pass a background context (so should replicate the prior behavior in catchpointdump, telemetry update service, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants