p2p: rate limit outgoing p2p http connections#5931
Merged
algorandskiy merged 8 commits intoalgorand:feature/p2pfrom Feb 7, 2024
Merged
p2p: rate limit outgoing p2p http connections#5931algorandskiy merged 8 commits intoalgorand:feature/p2pfrom
algorandskiy merged 8 commits intoalgorand:feature/p2pfrom
Conversation
1469fbc to
c5d2a66
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5931 +/- ##
===============================================
+ Coverage 55.67% 56.06% +0.39%
===============================================
Files 482 481 -1
Lines 68120 68072 -48
===============================================
+ Hits 37927 38167 +240
+ Misses 27570 27296 -274
+ Partials 2623 2609 -14 ☔ View full report in Codecov by Sentry. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
P2PNetworkto produce rate limiting outgoing HTTP clients. There are some some movements into subpackages to allow bothnetwork,p2p,peerstoreto use some utilities/functionality.network/addrnetwork/phonebook(to make peerstore's interface compatible with phonebook)network/limitcallerHad to modify phonebook interface to accept both string and
p2p.peer.AddrInfo(alternative is to marshalAddrInfoto bytes, cast and unmarshal but it is kind of the same). Plus, the current peerstore's implementation ofPhonebookinterface uses "host:port" as peerID and works only with "host:port" addresses and not with any kind of p2p addresses so it requires some change anyway. This is a first step.Test Plan
Added a unit test.