Skip to content

p2p: support block request redirects for p2p addresses#5929

Merged
algorandskiy merged 1 commit intoalgorand:feature/p2pfrom
algorandskiy:pavel/p2p-parsehosturl
Feb 5, 2024
Merged

p2p: support block request redirects for p2p addresses#5929
algorandskiy merged 1 commit intoalgorand:feature/p2pfrom
algorandskiy:pavel/p2p-parsehosturl

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

Support p2p addresses (multiaddr) in block service redirect code.

Test Plan

Added unit test.

@algorandskiy algorandskiy added Enhancement p2p Work related to the p2p project labels Feb 2, 2024
@algorandskiy algorandskiy self-assigned this Feb 2, 2024
@algorandskiy algorandskiy force-pushed the pavel/p2p-parsehosturl branch from 7c11aae to 463d06c Compare February 2, 2024 21:53
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ba8b2cd) 55.99% compared to head (463d06c) 56.02%.

Files Patch % Lines
rpcs/blockService.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           feature/p2p    #5929      +/-   ##
===============================================
+ Coverage        55.99%   56.02%   +0.02%     
===============================================
  Files              482      482              
  Lines            68062    68069       +7     
===============================================
+ Hits             38112    38136      +24     
+ Misses           27346    27333      -13     
+ Partials          2604     2600       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 200e0bb into algorand:feature/p2p Feb 5, 2024
@algorandskiy algorandskiy deleted the pavel/p2p-parsehosturl branch March 16, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement p2p Work related to the p2p project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant