p2p: http catchpoints support#5924
Merged
algorandskiy merged 4 commits intoalgorand:feature/p2pfrom Feb 5, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5924 +/- ##
===============================================
+ Coverage 55.98% 56.06% +0.07%
===============================================
Files 482 482
Lines 68057 68108 +51
===============================================
+ Hits 38103 38186 +83
+ Misses 27347 27318 -29
+ Partials 2607 2604 -3 ☔ View full report in Codecov by Sentry. |
gmalouf
reviewed
Feb 2, 2024
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
Asked a few questions, okay with approving after get a response to those.
gmalouf
approved these changes
Feb 5, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P2P HTTP support for ledger service:
GetHTTPRequestConnection:StreamChainingHostwrapper forlibp2p.host.Hostallows multiple stream handlers for the same protocol.IDTest Plan
Added unit test for fetcher, service and new p2p stream wrapper.