p2p: HTTP catchup over p2p network#5898
Merged
algorandskiy merged 16 commits intoalgorand:feature/p2pfrom Jan 29, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/p2p #5898 +/- ##
===============================================
+ Coverage 55.91% 56.04% +0.12%
===============================================
Files 481 482 +1
Lines 67938 68078 +140
===============================================
+ Hits 37987 38153 +166
+ Misses 27375 27326 -49
- Partials 2576 2599 +23 ☔ View full report in Codecov by Sentry. |
ac3bdc5 to
42db834
Compare
* modify setupFullNodes to get rid of non-closing pending ledgers * re-enable some skipped to tests
42db834 to
8f49ad0
Compare
algorandskiy
commented
Jan 26, 2024
bbc379f to
17a8fe8
Compare
jasonpaulos
approved these changes
Jan 29, 2024
Contributor
jasonpaulos
left a comment
There was a problem hiding this comment.
I don't know a lot about libp2p HTTP handling, but this looks good. I've left some spelling corrections and a test suggestion, but those are minor
Contributor
Author
|
Thank you Jason, I'll include these fixes into a followup PR I already started. |
Contributor
Author
|
Applied in #5922 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slices.SortFuncinterface changegorilla/muxrouter and registers self as a root (/) handler.universalFetcherto distinguish between p2p and regular tcp peers, peer'srootURLchecked if it is a multiaddrBackoffDiscovery::FindPeershas a cache so we are not making crazy number or requests to DHT.Test Plan
Added a unit test to
./nodeto test http catchup via p2p transport.Reenabled some skipped tests in node_test.go