AVM: Add global GenesisHash#5858
Merged
Merged
Conversation
jannotti
force-pushed
the
global-genhash
branch
3 times, most recently
from
d7edd37 to
77aabad
Compare
Paranoid code (especially logicsigs) can check if they are on testnet.
jannotti
force-pushed
the
global-genhash
branch
from
77aabad to
b36fb12
Compare
algorandskiy
previously approved these changes
Dec 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5858 +/- ##
==========================================
- Coverage 55.90% 55.89% -0.02%
==========================================
Files 477 477
Lines 67333 67350 +17
==========================================
- Hits 37643 37642 -1
- Misses 27137 27153 +16
- Partials 2553 2555 +2 ☔ View full report in Codecov by Sentry. |
algorandskiy
previously approved these changes
Dec 7, 2023
jasonpaulos
previously approved these changes
Dec 7, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
Looks good, just a test suggestion
jannotti
dismissed stale reviews from jasonpaulos and algorandskiy
via
c0cfb9e
jasonpaulos
approved these changes
Dec 7, 2023
algorandskiy
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paranoid code (especially logicsigs) can check if they are on testnet.
Added some extra test code that seems superfluous to this change (because it is!) But they are good tests that I needed while pursuing other ways of doing this.