tests: dump logs if e2e test node exited with an error#5856
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Dec 6, 2023
Merged
tests: dump logs if e2e test node exited with an error#5856algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
+ Coverage 55.90% 55.91% +0.01%
==========================================
Files 477 477
Lines 67333 67333
==========================================
+ Hits 37643 37651 +8
+ Misses 27137 27132 -5
+ Partials 2553 2550 -3 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Dec 6, 2023
onetechnical
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time to time some catchup nightly e2e tests fail with a node non-zero exit status after the test completion. No luck reproducing it locally/branches/etc so adding extra logging to master.
Test Plan
This is test fixture modification.